What's the rational? Didn't we add the option because the overhead was significant? Did anything change?

Back in time, we added that flag to prevent apps that were injecting concrete implementations instead of interfaces to break when upgrading to 6.1.

IIRC, there was no relation with any overhead at that time.

For the record, users doing:

publicfunction__construct(ObjectNormalizer$normalizer) {}

instead of:

publicfunction__construct(#[Autowire('...')]NormalizerInterface$normalizer) {}

had broken app when enabling the debug. That was why we have hidden the decoration behind a flag.

But maybe at least we can change the default? So that we can remove the recipe definition at some point?

Which means:

• requiring to define explicitly the value in 7.3
• change the default in 8.0

WDYT?

Here is the PR introducing the flag:#46625

Indeed, adding this option was a quick fix. It isn't meant to stay

There are still few tests to fix for information

Why not deprecate the option instead?

Because the actual default value isfalse, and I want to have atrue in the end, I think the steps should be:

• deprecate not setting the value totrue (7.3)
• deprecate the config option (8.1) - as it'll betrue for sure
• remove the config option (9.0)

Deprecating the config option directly (and therefore removing it in 8.0) will not allow users to adapt their code first.

But it may be ok for such a change. WDYT?

Deprecating the option sounds good to me. The notice is what will actually urge people to fix their code so that it works with the serializer collector, no matter if it's about changing the default or removing that option. I think the latter gives enough time, no need for more.

The related tests are fixed now.

@chalasr if you mean deprecating the option whatever the value, then I don't agree: this would annoy people that just updated their recipe / created a new project since 6.1, while at the same time create a migration risk, with a leaky BC layer.

Fair enough

In the upgrade note, it might be nice to tell about what you wrote in#60069 (comment) BTW.

Here you go:https://github.com/symfony/symfony/compare/fda5371b559b9c03113c726a7e33dbbd176339b3..29c75621c740dea5df27d86fff4293ae5c50b673

Thank you@mtarld.