Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Use duplicate_preferred_choices to set value of ChoiceType#60054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromaleho:6.4
Mar 28, 2025

Conversation

aleho
Copy link
Contributor

When the preferred choices are not duplicated an option has to be selected in the group of preferred choices.

Closes#58561

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58561
LicenseMIT

When the preferred choices are not duplicated an option has to be selected in the group of preferred choices.

buchmayr reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@alehoaleho changed the base branch from7.3 to6.4March 26, 2025 16:42
@aleho
Copy link
ContributorAuthor

Thank you,@carsonbot

@stof
Copy link
Member

it would be great to add a test covering this case (we have tests for the rendering of forms)

aleho reacted with thumbs up emoji

When the preferred choices are not duplicated an option has to beselected in the group of preferred choices.Closessymfony#58561
@aleho
Copy link
ContributorAuthor

aleho commentedMar 27, 2025•
edited
Loading

@stof I added tests for both cases, with duplication on and off, to make sure my changes don't break anything.

@fabpotfabpot modified the milestones:7.3,6.4Mar 28, 2025
@fabpot
Copy link
Member

Thank you@aleho.

@fabpotfabpot merged commit5a0d245 intosymfony:6.4Mar 28, 2025
9 of 11 checks passed
@stof
Copy link
Member

To fix thelow-deps job in the CI, you need to update the min version of symfony/form in the require-dev of the twig-bridge (the high-deps will be fixed when merging up)

This was referencedMar 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

duplicate_preferred_choices => false - won't populate form option value on edit
4 participants
@aleho@carsonbot@stof@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp