Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer][TwigBridge] Revert "Add support for translatable objects"#60052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 3 commits intosymfony:7.3fromkbond:revert-59967
Mar 26, 2025

Conversation

kbond
Copy link
Member

QA
Branch?7.3
Bug fix?no
New feature?no
Deprecations?no
IssuesReverts#60047 &#59967
LicenseMIT

#59967 introduced a BC break so we need to revert and find another solution.

@kbond
Copy link
MemberAuthor

Sorry about that@norkunas. Could#59967 (comment) be a solution? If so, we can document this.

@stof
Copy link
Member

As we were already introduce agetTranslatableSubject getter, we might introduce a corresponding new setter (and we should actually support TranslatableInterface)

@kbond
Copy link
MemberAuthor

As we were already introduce a getTranslatableSubject getter, we might introduce a corresponding new setter

I'm not really a fan of this for thereason@nicolas-grekas mentioned in#59967

@stof
Copy link
Member

I have no idea what his suggestion is about. It makes no sense for Email to implement TranslatableInterface.

On the other hand, supporting translatable subjects is probably a use case for any localized project (and would allow avoiding to inject the translator in each place creating an Email object to translate it before callingsubject, just like TemplatedEmail is about avoiding to render the Twig template explicitly).

@kbond
Copy link
MemberAuthor

adds cross-cutting concerns to the base class (= combinatory explosion)

This was the specific reason I was referring to. I'm thinking to document#59967 (comment) as the best way to translate the subject. I get that it doesn't work if not using Twig, but in this case, you'd have to have an alternate system to translate the body/html - so why not translate subject within the same system.

@fabpot
Copy link
Member

Thank you@kbond.

@fabpotfabpot merged commitd9e5036 intosymfony:7.3Mar 26, 2025
10 of 11 checks passed
@kbondkbond deleted the revert-59967 branchMarch 26, 2025 21:26
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot left review comments

@stofstofstof approved these changes

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

4 participants
@kbond@stof@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp