Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ObjectMapper] CS fixes#60031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
GromNaN merged 1 commit intosymfony:7.3fromOskarStark:fix/object-mapper
Mar 25, 2025
Merged

Conversation

OskarStark
Copy link
Contributor

QA
Branch?7.3
Bug fix?no
New feature?no
Deprecations?no
Issues--
LicenseMIT

Copy link
Member

@alexandre-dauboisalexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After Jérôme's comment

@@ -100,7 +100,7 @@ public function testHasNothingToMapTo()
{
$this->expectException(MappingException::class);
$this->expectExceptionMessage('Mapping target not found for source "class@anonymous".');
(new ObjectMapper())->map(new class(){});
(new ObjectMapper())->map(new class {});
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

{
$this->expectException(MappingTransformException::class);
$this->expectExceptionMessage('Cannot map "stdClass" to a non-object target of type "string".');

$u = new \stdClass;
$u = new \stdClass();
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

GromNaN reacted with thumbs up emoji
{
$this->expectException(MappingException::class);
$this->expectExceptionMessage(sprintf('Expected the mapped object to be an instance of "%s" but got "stdClass".', ClassWithoutTarget::class));
$this->expectExceptionMessage(\sprintf('Expected the mapped object to be an instance of "%s" but got "stdClass".', ClassWithoutTarget::class));
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There should also be a CS fixer for this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, didn't found it on the go

@OskarStark
Copy link
ContributorAuthor

cc@nicolas-grekas and@fabpot regarding the CS settings

@GromNaN
Copy link
Member

Thank you@OskarStark.

@GromNaNGromNaN merged commitf803dc1 intosymfony:7.3Mar 25, 2025
4 of 11 checks passed
@OskarStarkOskarStark deleted the fix/object-mapper branchMarch 25, 2025 12:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@GromNaNGromNaNGromNaN left review comments

@soyukasoyukasoyuka approved these changes

@xabbuhxabbuhxabbuh approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

6 participants
@OskarStark@GromNaN@soyuka@xabbuh@alexandre-daubois@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp