Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] useTable::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+#60030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.2fromxabbuh:doctrine-dbal-6867
Mar 26, 2025

Conversation

xabbuh
Copy link
Member

QA
Branch?7.2
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

@xabbuh
Copy link
MemberAuthor

Status: Needs work

@xabbuhxabbuh changed the titleuse Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+[Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+Mar 24, 2025
@xabbuhxabbuh requested a review fromchalasr as acode ownerMarch 24, 2025 16:33
@carsonbotcarsonbot changed the title[Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+Mar 24, 2025
@xabbuhxabbuh changed the titleuse Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+[DoctrineBridge][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+Mar 24, 2025
Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please also update the Cache and Lock component, and the session storage in HttpFoundation

@xabbuhxabbuh changed the title[DoctrineBridge][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+[DoctrineBridge][HttpFoundation][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+Mar 24, 2025
@xabbuhxabbuh changed the title[DoctrineBridge][HttpFoundation][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+[Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+Mar 24, 2025
@OskarStarkOskarStark changed the title[Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+[Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] useTable::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+Mar 24, 2025
@xabbuh
Copy link
MemberAuthor

Status: Needs review

@carsonbotcarsonbot changed the title[Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] useTable::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+[Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] useTable::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+Mar 24, 2025
@alexandre-daubois
Copy link
Member

I think you missedEntityTypeTest andUniqueEntityValidatorTest? The deprecation is still raised in these cases

@xabbuh
Copy link
MemberAuthor

@alexandre-daubois The remaining deprecations triggered by the DoctrineBridge tests should be solved withdoctrine/orm#11882.

alexandre-daubois reacted with thumbs up emoji

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Strange move from the orm, DX wise, isn't it?

GromNaN reacted with thumbs up emoji
@xabbuh
Copy link
MemberAuthor

everything is green again \o/

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit2f6b2e6 intosymfony:7.2Mar 26, 2025
9 of 11 checks passed
@xabbuhxabbuh deleted the doctrine-dbal-6867 branchMarch 26, 2025 08:03
@fabpotfabpot mentioned this pull requestMar 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

@mtarldmtarldmtarld approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

7 participants
@xabbuh@alexandre-daubois@fabpot@nicolas-grekas@stof@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp