Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Serializer] Fix ObjectNormalizer default context with named serializers#60026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+110 −28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3e641ad to6dde315Comparesrc/Symfony/Component/Serializer/DependencyInjection/SerializerPass.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas approved these changesMar 24, 2025
src/Symfony/Component/Serializer/DependencyInjection/SerializerPass.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
HypeMC commentedMar 24, 2025
src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
6dde315 to80d993fCompareUh oh!
There was an error while loading.Please reload this page.
fabpot approved these changesMar 26, 2025
mtarld approved these changesMar 26, 2025
Thank you@HypeMC. |
02161b7 intosymfony:7.2 4 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in#59639, the main problem is that arguments have precedence over bindings, and children inherit arguments from their parents.
This PR moves the logic for setting the default context of
ObjectNormalizerfrom the extension to theSerializerPass, where only bindings are used.