Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[TypeInfo] AddArrayShapeType::$sealed#59981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
As 7.3 has been released yet, I think that 8.2 low-deps failures can be ignored. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
62a0dab to1e70c86CompareUh oh!
There was an error while loading.Please reload this page.
1e70c86 to9030a26Comparesrc/Symfony/Component/TypeInfo/Tests/TypeResolver/StringTypeResolverTest.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
9030a26 to0bd93a0Compare| @@ -56,6 +60,14 @@ public function __construct(array $shape) | |||
| ksort($sortedShape); | |||
| $this->shape = $sortedShape; | |||
| if ($this->extraKeyType xor $this->extraValueType) { | |||
| throw new InvalidArgumentException(\sprintf('You must provide as value for "$%s" when "$%s" is provided.', ...($this->extraKeyType ? ['extraValueType', 'extraKeyType'] : ['extraKeyType', 'extraValueType']))); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't understand this error message.
| @@ -56,6 +60,14 @@ public function __construct(array $shape) | |||
| ksort($sortedShape); | |||
| $this->shape = $sortedShape; | |||
| if ($this->extraKeyType xor $this->extraValueType) { | |||
| throw new InvalidArgumentException(\sprintf('You must provide as value for "$%s" when "$%s" is provided.', ...($this->extraKeyType ? ['extraValueType', 'extraKeyType'] : ['extraKeyType', 'extraValueType']))); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| thrownewInvalidArgumentException(\sprintf('You must provideas value for "$%s" when "$%s" is provided.',...($this->extraKeyType ?['extraValueType','extraKeyType'] : ['extraKeyType','extraValueType']))); | |
| thrownewInvalidArgumentException(\sprintf('You must providea value for "$%s" when "$%s" is provided.',$this->extraKeyType ?'extraValueType' :'extraKeyType',$this->extraKeyType ?'extraKeyType' :'extraValueType')); |
0bd93a0 tofded1ebCompareThank you@mtarld. |
452ad95 intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Implement sealed syntax for array shape type, as suggested in#59827 (comment).