Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MonologBridge] Add ability to react to console input being interactive or not#59955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dkarlovi wants to merge1 commit intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromsigwinhq:feat/interactive-logger

Conversation

dkarlovi
Copy link
Contributor

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#58715
LicenseMIT

See#58715 for example.

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@dkarlovidkarloviforce-pushed thefeat/interactive-logger branch from4ef2980 to5ac3f1dCompareMarch 11, 2025 17:22
@dkarlovi
Copy link
ContributorAuthor

@ro0NL this is offtopic for this PR, feel free to discuss in#58715.

@dkarlovi
Copy link
ContributorAuthor

but OK. please preserve BC at all cost.

Yes, this is expected to be 100% BC, it's opt-in for 7.x for sure, maybe it makes sense to change that for 8.x, but that's not up to me.

@dkarlovi
Copy link
ContributorAuthor

Config partsymfony/monolog-bundle#504


private function isInteractiveOnlyEnabled(): bool
{
return $this->interactiveOnly && $this->input && $this->input->isInteractive();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why do we need theinteractiveOnly flag? Is determining if the console is interactive via the input not enough?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The input will always be injected, but you opt in to "interactive only" mode via config, see#58715 for an example, it would be a BC break without it.

@dkarlovidkarlovi requested a review fromfabpotMarch 31, 2025 14:40
@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofAwaiting requested review from stof

@ro0NLro0NLAwaiting requested review from ro0NL

@fabpotfabpotAwaiting requested review from fabpot

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

[Console] allow the console logging handler to work and prevent propagation only when interactive
5 participants
@dkarlovi@carsonbot@fabpot@stof@ro0NL
[8]ページ先頭
©2009-2025 Movatter.jp