Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] AddMONGODB_ID to requirement patterns#59922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromGromNaN:requirement-mongodb-id
Mar 8, 2025

Conversation

GromNaN
Copy link
Member

@GromNaNGromNaN commentedMar 6, 2025•
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

TheMongoDB ObjectID is a 12-bytes binary value represented as an hexadecimal string of 24 characters.

They are used by default in Doctrine MongoDB ODM.

@carsonbotcarsonbot added this to the7.3 milestoneMar 6, 2025
@carsonbotcarsonbot changed the title[Routing] AddMONGODB_ID to requirement patterns[Routing] AddMONGODB_ID to requirement patternsMar 6, 2025
@GromNaNGromNaN requested a review fromCopilotMarch 6, 2025 10:09
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PR Overview

This PR adds a new constant, Requirement::MONGODB_ID, to support validation of MongoDB ObjectIDs in hexadecimal format. The changelog has been updated accordingly.

  • Added changelog entry documenting the new constant for MongoDB ObjectID validation

Reviewed Changes

FileDescription
src/Symfony/Component/Routing/CHANGELOG.mdUpdated changelog to document the addition of the new constant

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@GromNaNGromNaNforce-pushed therequirement-mongodb-id branch from7a2aaaf to44d621bCompareMarch 6, 2025 10:27
@GromNaNGromNaNforce-pushed therequirement-mongodb-id branch from44d621b to84085d5CompareMarch 6, 2025 15:04
@fabpot
Copy link
Member

Thank you@GromNaN.

@fabpotfabpot merged commit5e59554 intosymfony:7.3Mar 8, 2025
11 checks passed
@GromNaNGromNaN deleted the requirement-mongodb-id branchMarch 8, 2025 16:02
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

@mtarldmtarldmtarld approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

6 participants
@GromNaN@fabpot@OskarStark@alexandre-daubois@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp