Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DependencyInjection] Leverage native lazy objects for lazy services#59913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if (!$manager instanceof LazyLoadingInterface) { | ||
| throw new \LogicException(\sprintf('Resetting a non-lazy manager service is not supported. Declare the "%s" service as lazy.', $name)); | ||
| } | ||
| trigger_deprecation('symfony/doctrine-bridge', '7.3', 'Support for proxy-manager is deprecated.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This case should never happen (who would use proxy-manager directly instead of Symfony's lazy services for the Doctrine EM!?), still added for completeness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
isn't this deprecation always triggered on PHP 8.3 and older ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it's guarded byif (!$manager instanceof LazyLoadingInterface) { (note the!) so only when ppl use proxy-manager, which we don't anymore thanks to var-exporter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no. This deprecation is triggeredafter that if, when we haven't thrown an exception (and so in the case where we will actually reset the object)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh, I missed that the case of lazy objects using var-exporter are handledbefore the check for PHP 8.4, so this is not the code path we reach in modern projects.
855b264 to02958b9Compare02958b9 toed695a6Compare0c11d82 intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Nice! Could this PR possibly also improve performance? Any idea on how to benchmark that? |
When a service is lazy, we can leverage native lazy objects on PHP 8.4.
(Note that we still need var-exporter to generate lazy proxies when using the
proxytag - aka when proxying "by interface".)