Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Keep submitted values whenkeep_as_list option of collection type is enabled#59910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@kells64000
Copy link

QA
Branch?7.2
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#57430
LicenseMIT

When thekeep_as_list option ofCollectionType is true, its entries lose their values when re-displaying the form with submitted data.

This fix only concerns the 2nd point of thelinked issue.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStarkOskarStark changed the title[Form] Keep submitted values when keep_as_list option of collection type is enabled[Form] Keep submitted values whenkeep_as_list option of collection type is enabledMar 5, 2025
@kells64000kells64000force-pushed thefix/form-collection-type-keepaslist-keep-submitted-data branch from2dde5d2 to4619258CompareMarch 5, 2025 08:14
@kells64000
Copy link
Author

Friendly ping for a review@xabbuh@yceruto 🙏

mariecharles, rdelbaere, and StevenRenaux reacted with thumbs up emoji

@welcoMatticwelcoMattic self-requested a reviewMay 26, 2025 09:43
@kells64000
Copy link
Author

@xabbuh Does this sound good to you?

xabbuh added a commit that referenced this pull requestJun 10, 2025
…eCat)This PR was merged into the 7.2 branch.Discussion----------[Form] Fix `keep_as_list` when data is not an array| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | Fix part of#57430| License       | MITThe `CollectionType` handles not only arrays but also `ArrayAccess&Traversable`. However when setting its `keep_as_list` option, `array_values` would then be called and crash.To avoid this, this PR reindexes the data by getting its keys and unsetting them. This is because unsetting in a loop can produce counter-intuitive results; e.g. [`ArrayIterator` would skip indexes](https://www.php.net/manual/en/arrayiterator.offsetunset.php).Note that#57430 mentions another issue that would be fixed by#59910.Commits-------6c964e7 [Form] Fix `keep_as_list` when data is not an array
@kells64000kells64000force-pushed thefix/form-collection-type-keepaslist-keep-submitted-data branch frome1c2d57 to78214dcCompareJune 11, 2025 08:36
…ype is enabledCo-authored-by: mariecharles marie.charles@hetic.net
@kells64000kells64000force-pushed thefix/form-collection-type-keepaslist-keep-submitted-data branch from78214dc tobac56deCompareJune 11, 2025 08:44
@xabbuh
Copy link
Member

Thank you@kells64000.

@xabbuhxabbuh merged commitac794a7 intosymfony:7.2Jun 11, 2025
10 of 11 checks passed
This was referencedJun 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@dunglasdunglasAwaiting requested review from dunglas

@kbondkbondAwaiting requested review from kbond

@chalasrchalasrAwaiting requested review from chalasr

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@jderussejderusseAwaiting requested review from jderusse

+1 more reviewer

@StevenRenauxStevenRenauxStevenRenaux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

7 participants

@kells64000@carsonbot@xabbuh@nicolas-grekas@welcoMattic@yceruto@StevenRenaux
[8]ページ先頭
©2009-2025 Movatter.jp