Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Reduce keepalive request noise#59908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alexandre-daubois merged 1 commit intosymfony:7.2fromro0NL:patch-1
Mar 4, 2025

Conversation

ro0NL
Copy link
Contributor

QA
Branch?7.2
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix #...
LicenseMIT

Currentlymessenger:consume --keepalive creates a lot of noise (INFO log every 5 sec by default).

13:34:59 INFO      [messenger] Sending keepalive request.13:35:04 INFO      [messenger] Sending keepalive request.

I propose to use DEBUG instead. We can also remove this log, since there's already a keepalive log per message ID:

$this->logger?->info('Sending keepalive request.', [
'transport' =>$transportName,
'message_id' =>$envelope->last(TransportMessageIdStamp::class)?->getId(),
]);

cc@HypeMC

valtzu reacted with thumbs up emoji
@alexandre-daubois
Copy link
Member

Thank you@ro0NL.

@alexandre-dauboisalexandre-daubois merged commit653e42d intosymfony:7.2Mar 4, 2025
8 of 11 checks passed
@ro0NLro0NL deleted the patch-1 branchMarch 4, 2025 13:11
@fabpotfabpot mentioned this pull requestMar 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

5 participants
@ro0NL@alexandre-daubois@fabpot@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp