Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyInfo] DeprecateType#59902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 2 commits intosymfony:7.3frommtarld:fix/deprecate-property-info-type
Mar 22, 2025

Conversation

mtarld
Copy link
Contributor

QA
Branch?7.3
Bug fix?no
New feature?no
Deprecations?yes
Issues
LicenseMIT

A new attempt to#53160, now thatsymfony/type-info is not experimental anymore.

Deprecates:

  • Type class in favor of theType class ofsymfony/type-info
  • PropertyTypeExtractorInterface::getTypes() in favor of thePropertyTypeExtractorInterface::getType() method
  • ConstructorArgumentTypeExtractorInterface::getTypesFromConstructor() in favor of theConstructorArgumentTypeExtractorInterface::getTypeFromConstructor() method

The work for upgrading dependent packages has begun already:

@alexandre-daubois
Copy link
Member

I think your tests should expect deprecations as well by using theExpectDeprecationTrait, additionally to thelegacy group. It also helps to show explicitly why the legacy group is used and speed up cleaning on next major 🙂

@mtarldmtarldforce-pushed thefix/deprecate-property-info-type branch fromefaf7fe toa9d3291CompareMarch 3, 2025 13:51
@mtarld
Copy link
ContributorAuthor

Indeed, that'll be great! Updated.

alexandre-daubois reacted with rocket emoji

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🎉 (2 minor comments)

@mtarldmtarldforce-pushed thefix/deprecate-property-info-type branch froma9d3291 to3decf95CompareMarch 5, 2025 13:28
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rebase needed

@mtarldmtarldforce-pushed thefix/deprecate-property-info-type branch from3decf95 tof819aedCompareMarch 22, 2025 13:45
@chalasr
Copy link
Member

Thank you@mtarld.

@chalasrchalasr merged commit2468bae intosymfony:7.3Mar 22, 2025
11 checks passed
@mtarldmtarld deleted the fix/deprecate-property-info-type branchMarch 22, 2025 17:27
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@chalasrchalasrchalasr approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

6 participants
@mtarld@alexandre-daubois@chalasr@nicolas-grekas@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp