Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] add newDatePointType Doctrine type#59900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromgarak:datepoint-type
Mar 24, 2025

Conversation

garak
Copy link
Contributor

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#59889
LicenseMIT

Add a new DoctrineType for the DatePoint class.
Please take a look at the issue mentioned above for more details.

@carsonbotcarsonbot added this to the7.3 milestoneMar 3, 2025
@OskarStarkOskarStark changed the titleadd new DatePointType Doctrine typeadd newDatePointType Doctrine typeMar 3, 2025
@carsonbotcarsonbot changed the titleadd newDatePointType Doctrine type[DoctrineBridge] add newDatePointType Doctrine typeMar 3, 2025
@garak
Copy link
ContributorAuthor

I can't understand the psalm failures, any help will be appreciated.
Moreover, I see that fabbot complains because I added some tests with return type, does it make sense?

@OskarStark
Copy link
Contributor

Moreover, I see that fabbot complains because I added some tests with return type, does it make sense?

Yes, we avoid thevoid return type in the Symfony codebase

garak reacted with thumbs up emoji

@garak
Copy link
ContributorAuthor

I fixed the return types. The unit test failures seem unrelated.
I still need a hint about fixing the psalm inspection, thanks.

@garakgarakforce-pushed thedatepoint-type branch 2 times, most recently from6bc479d to4608390CompareMarch 8, 2025 17:30
@GromNaN
Copy link
Member

Note for the DoctrineBundle integration: in addition to adding the type to the DBAL Types registry, this new type should be associated to theDatePoint property type in thetyped field mapper.

@fabpot
Copy link
Member

Thank you@garak.

@fabpotfabpot merged commit6872336 intosymfony:7.3Mar 24, 2025
3 of 7 checks passed
@garakgarak deleted the datepoint-type branchMarch 24, 2025 08:25
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@GromNaNGromNaNGromNaN left review comments

@derrabusderrabusderrabus left review comments

@xabbuhxabbuhxabbuh left review comments

@alexandre-dauboisalexandre-dauboisalexandre-daubois left review comments

@mtarldmtarldmtarld left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[DoctrineBridge] DatePoint type
10 participants
@garak@OskarStark@GromNaN@fabpot@nicolas-grekas@derrabus@xabbuh@alexandre-daubois@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp