NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.3k

[VarExporter] Leverage native lazy objects#59890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.3fromnicolas-grekas:ve-native-lazy-objects

Mar 22, 2025

Merged

[VarExporter] Leverage native lazy objects#59890

nicolas-grekas merged 1 commit intosymfony:7.3fromnicolas-grekas:ve-native-lazy-objects

Mar 22, 2025

+981 −226

Conversation

Copy link

Member

nicolas-grekas commentedMar 2, 2025•
edited
Loading

Q	A
Branch?	7.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	-
License	MIT

Let's leverage native lazy objects.

Instead of keeping/updating LazyGhostTrait and LazyProxyTrait, I'm deprecating them in favor of using native lazy proxies directly.

There is one use case that is not covered by native lazy objects: lazy decorators - aka lazy proxies built against an interface or an internal class. For this use case, we keepProxyHelper::generateLazyProxy().

carsonbot added Status: Needs Review Feature VarExporter labels

Mar 2, 2025

carsonbot added this to the7.3 milestone

Mar 2, 2025

nicolas-grekas force-pushed theve-native-lazy-objects branch 2 times, most recently fromae65a7a to3b27972Compare

March 3, 2025 09:45

nicolas-grekas force-pushed theve-native-lazy-objects branch 2 times, most recently from0bbd405 to7badfb5Compare

March 14, 2025 16:44

This comment was marked as outdated.

nicolas-grekas force-pushed theve-native-lazy-objects branch 2 times, most recently from9852544 to1d14933Compare

March 15, 2025 13:04

nicolas-grekas mentioned this pull request

Mar 15, 2025

Various cleanups#59980

Merged

nicolas-grekas added a commit that referenced this pull request

Mar 15, 2025

minor#59980Various cleanups (nicolas-grekas)

6211084

This PR was merged into the 7.3 branch.Discussion----------Various cleanups| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITFound while working on#59890Commits-------18390f1 Various cleanups

nicolas-grekas force-pushed theve-native-lazy-objects branch from1d14933 toaaf3d4aCompare

March 15, 2025 13:25

Copy link

MemberAuthor

nicolas-grekas commentedMar 15, 2025•
edited
Loading

Self-review:

Add support for PHP 8.4 Lazy Objects RFC with configuration flag doctrine/orm#11853 is needed to fix the deprecation on doctrine-bridge
using native lazy objects is incompatible with decorating internal classes - this should be changed
the code is too complex: it handles cases that are better dealt with using native lazy proxies

Status: needs work

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Mar 15, 2025

Copy link

Member

stof commentedMar 17, 2025

Be careful. Doctrine ORM 2.x is not EOL yet and it already supports using var-exporter (but will probably not receive a backport of the support for native lazy objects). This might impact the deprecation plan.

nicolas-grekas force-pushed theve-native-lazy-objects branch 4 times, most recently from6b9b1fd toe382b2fCompare

March 21, 2025 15:56

Copy link

MemberAuthor

nicolas-grekas commentedMar 21, 2025

Doctrine ORM 2.x is not EOL yet and it already supports using var-exporter (but will probably not receive a backport of the support for native lazy objects). This might impact the deprecation plan.

I don't think this should impact us: ppl have a way to fix the deprecation: upgrade. The day where 2.x will be EOLed is close anyway.

After many error-n-trial, I just pushed what I think is the implementation that works. First I thought we could use hooks to proxy all properties, but it happens those are not really compatible with references, so that we have to keep using magic accessors to proxy them.

Status: needs review