Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] fix progress bar messing output in section when there is an EOL#59874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromjoelwurtz:fix/fix-progress-bar-eol
Mar 3, 2025

Conversation

joelwurtz
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
Issues#52446
LicenseMIT

This fix the progress bar making the output erase previous line when there is an EOL at the end of it

@carsonbotcarsonbot added this to the6.4 milestoneFeb 27, 2025
@joelwurtzjoelwurtz changed the titlefix(console): fix progress bar messing output in section when there i…fix(console): fix progress bar messing output in section when there is an EOLFeb 27, 2025
@joelwurtzjoelwurtzforce-pushed thefix/fix-progress-bar-eol branch 2 times, most recently from8283b46 toc93d5e0CompareFebruary 27, 2025 11:06
@joelwurtzjoelwurtz changed the titlefix(console): fix progress bar messing output in section when there is an EOL[Console] fix progress bar messing output in section when there is an EOLFeb 27, 2025
Copy link
Contributor

@cedric-annecedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

With the proposed fix, it works as expected with an endingPHP_EOL, but it still remove some lines when the endingPHP_EOL is not present, at least as long as the$message is an empty string.

@joelwurtz
Copy link
ContributorAuthor

Thanks for the insight@cedric-anne i added a test and changed the fix to make it work in both cases

@cedric-anne
Copy link
Contributor

I still have the issue if I use the following format:'[%bar%] %percent:3s%%' . PHP_EOL . '<comment>%message%</comment>'. I guess it is because it producesPHP_EOL . <comment></comment> that is not detected as an ending new line but is acting the same when rendered int he terminal.

@joelwurtz
Copy link
ContributorAuthor

I still have the issue if I use the following format:

Should be good, it now checks if last line is an empty message without formatting, also added a test case for your use case

Copy link
Contributor

@cedric-annecedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@carsonbotcarsonbot changed the title[Console] fix progress bar messing output in section when there is an EOLfix progress bar messing output in section when there is an EOLFeb 27, 2025
@carsonbotcarsonbot changed the titlefix progress bar messing output in section when there is an EOL[Console] fix progress bar messing output in section when there is an EOLFeb 27, 2025
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tested locally

@joelwurtzjoelwurtzforce-pushed thefix/fix-progress-bar-eol branch from68b4c1b to3f9fa83CompareMarch 3, 2025 17:15
@joelwurtzjoelwurtzforce-pushed thefix/fix-progress-bar-eol branch from3f9fa83 tocae2241CompareMarch 3, 2025 17:16
@fabpot
Copy link
Member

Thank you@joelwurtz.

@fabpotfabpot merged commit647dba0 intosymfony:6.4Mar 3, 2025
11 checks passed
@joelwurtzjoelwurtz deleted the fix/fix-progress-bar-eol branchMarch 3, 2025 19:22
This was referencedMar 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mtarldmtarldmtarld left review comments

@chalasrchalasrchalasr left review comments

@fabpotfabpotfabpot approved these changes

@cedric-annecedric-annecedric-anne approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

7 participants
@joelwurtz@cedric-anne@fabpot@mtarld@chalasr@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp