Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Add support forvalkey: /valkeys: schemes#59869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromnicolas-grekas:valkey
Mar 5, 2025

Conversation

nicolas-grekas
Copy link
Member

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

Valkey is getting a lot of traction, so let's support it as a new scheme (I'm not much into renaming everything :) )

@nicolas-grekasnicolas-grekasforce-pushed thevalkey branch 3 times, most recently from2153d49 tobcd9500CompareFebruary 26, 2025 17:34
@carsonbotcarsonbot changed the titleAdd support forvalkey: /valkeys: schemes[Cache] Add support forvalkey: /valkeys: schemesFeb 26, 2025
@nicolas-grekasnicolas-grekasforce-pushed thevalkey branch 4 times, most recently from7ba1fdf to90c665cCompareFebruary 26, 2025 18:29
@@ -174,28 +174,24 @@ public static function createConnection(#[\SensitiveParameter] string $dsn, arra

$params += $query + $options + self::$defaultConnectionOptions;

if (isset($params['redis_sentinel']) && isset($params['sentinel_master'])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This removes the fact that you cannot use those options together. You know silently ignoreredis_sentinel whensentinel_master (or the newsentinel) is set. Doesn't this introduce a potential WTF debugging moment if$query and$options both configure this using different names for instance ?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think the exception is useful so I still prefer removing it.
I improved the merging logic to account for this case.

@nicolas-grekas
Copy link
MemberAuthor

Comments addressed@stof, thanks for the review.

@nicolas-grekasnicolas-grekasforce-pushed thevalkey branch 7 times, most recently fromea420d0 to9ff20c0CompareFebruary 27, 2025 15:10
@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commitdb5108d intosymfony:7.3Mar 5, 2025
10 of 11 checks passed
@nicolas-grekasnicolas-grekas deleted the valkey branchMarch 5, 2025 09:22
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@mtarldmtarldmtarld approved these changes

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

6 participants
@nicolas-grekas@fabpot@stof@mtarld@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp