Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[JsonEncoder] Rename the component toJsonStreamer#59863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+2,522 −2,544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8a2f83f to657c998CompareMakes sense, even more when I think of how it's leveraged in#59655 |
657c998 toc0c4c02Comparec0c4c02 to924a01dComparefabpot approved these changesMar 3, 2025
Thank you@mtarld. |
af2f36b intosymfony:7.3 8 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make the intent of the component clearer, the
JsonEncodercomponent should be renamed toJsonStreamer, as its main goal is to handle JSON streams as efficiently as possible.In that way, it'll be harder for developers to get confused between this component and the
Serializer's JSON encoder.In that PR, the following public API has been updated:
EncoderInterface::encode()has been renamed toStreamWriterInterface::write()DecoderInterface::decode()has been renamed toStreamReaderInterface::read()JsonEncoderclass has been renamed toJsonStreamWriterJsonDecoderclass has been renamed toJsonStreamReaderJsonEncodableattribute has been renamed toJsonStreamableEncodedNameattribute has been renamed toStreamedNameValueTransformerInterface::getJsonValueType()has been renamed toValueTransformerInterface::getStreamValueType()ValueTransformer::$toJsonValuehas been renamed toValueTransformer::$nativeToStreamValueTransformer::$toNativeValuehas been renamed toValueTransformer::$streamToNative