Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Semaphore] skip failing tests on GitHub Actions with PHP 8.5#59846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedFeb 24, 2025
Q | A |
---|---|
Branch? | 6.4 |
Bug fix? | no |
New feature? | no |
Deprecations? | no |
Issues | |
License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FYI@tillkruss this skips segfaults on PHP 8.5 when Relay is used. (PR welcome to revert this PR once support is fixed)
Good catch, thanks@xabbuh. |
7c515b2
intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
tillkruss commentedFeb 24, 2025
@nicolas-grekas We'll fix it this week 👍 |
tillkruss commentedFeb 26, 2025
We rebuilt with the latest 8.5 version but it still crashing. Might just have to consider 8.5 unstable until it's RC1. |
michael-grunder commentedFeb 26, 2025
For a bit more context, it looks decidedly like an Building Relay inside the container fixes the problem and so does using a different source image. Unfortunately there is nothing obviously wrong with our 8.5 builds (e.g. warnings due to changing PHP internals). I'm still going to try and pinpoint the issue, but at the very least we'll make sure it's working/fixed when 8.5 is released. |