Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Semaphore] skip failing tests on GitHub Actions with PHP 8.5#59846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromxabbuh:semaphore-redis-php8.5
Feb 24, 2025

Conversation

xabbuh
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Issues
LicenseMIT

@carsonbotcarsonbot added this to the6.4 milestoneFeb 24, 2025
@carsonbotcarsonbot changed the title[Semaphore] skip failing tests on GitHub Actions with PHP 8.5[Semaphore] skip failing tests on GitHub Actions with PHP 8.5Feb 24, 2025
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FYI@tillkruss this skips segfaults on PHP 8.5 when Relay is used. (PR welcome to revert this PR once support is fixed)

@nicolas-grekas
Copy link
Member

Good catch, thanks@xabbuh.

@nicolas-grekasnicolas-grekas merged commit7c515b2 intosymfony:6.4Feb 24, 2025
11 checks passed
@xabbuhxabbuh deleted the semaphore-redis-php8.5 branchFebruary 24, 2025 10:49
@tillkruss
Copy link

@nicolas-grekas We'll fix it this week 👍

xabbuh reacted with heart emoji

@tillkruss
Copy link

We rebuilt with the latest 8.5 version but it still crashing. Might just have to consider 8.5 unstable until it's RC1.

@michael-grunder
Copy link

For a bit more context, it looks decidedly like anABI problem.

Building Relay inside the container fixes the problem and so does using a different source image. Unfortunately there is nothing obviously wrong with our 8.5 builds (e.g. warnings due to changing PHP internals).

I'm still going to try and pinpoint the issue, but at the very least we'll make sure it's working/fixed when 8.5 is released.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

5 participants
@xabbuh@nicolas-grekas@tillkruss@michael-grunder@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp