Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] fix cache data collector on late collect#59841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromdcmbrs:fix_cache_datacollector_late
Feb 26, 2025

Conversation

dcmbrs
Copy link
Contributor

@dcmbrsdcmbrs commentedFeb 23, 2025•
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#59838
LicenseMIT

@carsonbotcarsonbot changed the titlefix cache data collector on late collect[Cache] fix cache data collector on late collectFeb 23, 2025
@dcmbrsdcmbrs changed the base branch from5.4 to6.4February 23, 2025 11:15
Copy link
Member

@keraduskeradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add a test case that is showing the issue the change in code is fixing?

@dcmbrs
Copy link
ContributorAuthor

@keradus I added a test

keradus reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas added this to the6.4 milestoneFeb 24, 2025
@fabpot
Copy link
Member

@dcmbrs Can you rebase tour PR to get rid of the merge commit? Thank you?

@dcmbrs
Copy link
ContributorAuthor

I'm sorry I couldn't clean up the merge request commit and I don't know what's going on. I see many commits and changes, I have the impression that 7.3 has been merged onto this branch but yet I haven't pushed anything on my side. Could I get some help? I'm not used to working with forks and rebase

Or I do antoher PR et close this ?

@nicolas-grekasnicolas-grekasforce-pushed thefix_cache_datacollector_late branch from7647b09 to4b8bb5cCompareFebruary 26, 2025 10:58
@nicolas-grekas
Copy link
Member

(I fixed the rebase)

dcmbrs reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@dcmbrs.

@fabpotfabpot merged commit0266d3c intosymfony:6.4Feb 26, 2025
11 checks passed
nicolas-grekas added a commit that referenced this pull requestMar 13, 2025
This PR was merged into the 6.4 branch.Discussion----------[Cache] Fix missing cache data in profiler| Q             | A| ------------- | ---| Branch?       |  6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#59838| License       | MITThere was a problem with the rebase on PR#59841I added the fix and a test to check itCommits-------cc505f9 [Cache] fix data collector
This was referencedMar 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@keraduskeraduskeradus left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@jderussejderusseAwaiting requested review from jderusse

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

6 participants
@dcmbrs@fabpot@nicolas-grekas@keradus@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp