Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] drop comments while lexing unquoted strings#59830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromxabbuh:issue-59785
Mar 1, 2025

Conversation

xabbuh
Copy link
Member

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#59785
LicenseMIT

andrey-tech reacted with rocket emoji
@stof
Copy link
Member

IIRC, a Yaml comment starts with a# that is either at the beginning of the line or is following a whitespace, buturl: http://example.com/#about would not treatabout as a comment.
Can you add more tests covering such cases ?

mshannaq reacted with thumbs up emoji

@xabbuh
Copy link
MemberAuthor

hm indeed

Status: Needs work

@xabbuh
Copy link
MemberAuthor

should be good now

Status: Needs Review

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit642b714 intosymfony:6.4Mar 1, 2025
6 of 11 checks passed
@xabbuhxabbuh deleted the issue-59785 branchMarch 1, 2025 21:30
This was referencedMar 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@ro0NLro0NLro0NL left review comments

@fabpotfabpotfabpot approved these changes

@mtarldmtarldmtarld approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

6 participants
@xabbuh@stof@fabpot@ro0NL@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp