NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Cache] Enable namespace-based invalidation by prefixing keys with backend-native namespace separators#59813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.3fromnicolas-grekas:cache-ns-relax

Mar 23, 2025

Merged

[Cache] Enable namespace-based invalidation by prefixing keys with backend-native namespace separators#59813

nicolas-grekas merged 1 commit intosymfony:7.3fromnicolas-grekas:cache-ns-relax

Mar 23, 2025

Conversation

Copy link

Member

nicolas-grekas commentedFeb 19, 2025•
edited
Loading

Q	A
Branch?	7.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix#45599
License	MIT

This PR adds aNamespacedPoolInterface that describes how one can add namespace prefixes to cache pool keys.

This solves#45599 by allowing to use the: separator for Redis:

$cache->withSubNamespace('some-prefix')->get($key,fn () =>...);

Most importantly, this enables namespace-based cache invalidation, typically with namespaces generated by hashing some context.

carsonbot added Status: Needs Review Cache Feature labels

Feb 19, 2025

carsonbot added this to the7.3 milestone

Feb 19, 2025

This was referencedFeb 19, 2025

[Cache] Allow to use namespace delimiter in cache key#51603

Closed

[Cache] Allow to use namespace delimiter in cache key#54710

Closed

nicolas-grekas force-pushed thecache-ns-relax branch 4 times, most recently fromba82917 to1e71a0cCompare

February 19, 2025 16:15

Copy link

Member

stof commentedFeb 19, 2025

IfpushNamespace returns a new adapter, what is the use case forpopNamespace (which also returns a new adapter, and so won't return the "parent" ArrayAdapter for instance) ?

nicolas-grekas force-pushed thecache-ns-relax branch from1e71a0c to0ca7660Compare

February 20, 2025 09:30

Copy link

MemberAuthor

nicolas-grekas commentedFeb 20, 2025

@stof you're totally right! I removedpopNamespace and renamed thepushNamespace method towithSubNamespace.

nicolas-grekas force-pushed thecache-ns-relax branch 4 times, most recently from904427d to349fa7bCompare

February 20, 2025 09:51

Copy link

MemberAuthor

nicolas-grekas commentedFeb 20, 2025

Ready. Tests should be green after merge.

stof reviewed

Feb 20, 2025

View reviewed changes

src/Symfony/Component/Cache/Adapter/TagAwareAdapter.phpShow resolvedHide resolved

src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php OutdatedShow resolvedHide resolved

nicolas-grekas force-pushed thecache-ns-relax branch 2 times, most recently fromb733583 to80e4605Compare

February 21, 2025 07:52

nicolas-grekas force-pushed thecache-ns-relax branch 3 times, most recently fromda4eacf tob9b63deCompare

March 13, 2025 15:23

[Cache] Enable namespace-based invalidation by prefixing keys with ba…

81a8ceb

…ckend-native namespace separators

nicolas-grekas force-pushed thecache-ns-relax branch fromb9b63de to81a8cebCompare

March 13, 2025 15:25

Copy link

MemberAuthor

nicolas-grekas commentedMar 13, 2025

PR ready (failures will be fixed by merging)

Copy link

MemberAuthor

nicolas-grekas commentedMar 21, 2025

Any comment @symfony/mergers ?

kbond approved these changes

Mar 21, 2025

View reviewed changes

Copy link

Member

kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

❤️

carsonbot removed the Status: Needs Review label

Mar 21, 2025

carsonbot added the Status: Reviewed label

Mar 21, 2025

nicolas-grekas merged commit6ef1ab4 intosymfony:7.3

Mar 23, 2025

8 of 11 checks passed

nicolas-grekas mentioned this pull request

Mar 23, 2025

[Cache] Enable namespace-based invalidation by prefixing keys with back…symfony/symfony-docs#20802

Closed

nicolas-grekas deleted the cache-ns-relax branch

March 23, 2025 17:41

fabpot mentioned this pull request

May 2, 2025

Release v7.3.0-BETA1#60327

Merged

Copy link

Contributor

IndraGunawan commentedMay 29, 2025

thanks for this great feature@nicolas-grekas

what type-hint that should we use in the constructor to have this ability with autowiring? orNamespacedPoolInterface should be extendsCacheInterface ?

Copy link

MemberAuthor

nicolas-grekas commentedMay 29, 2025

Can you try using an intersection type of both? That should work!

Copy link

Contributor

IndraGunawan commentedMay 29, 2025

i did (https://symfony-devs.slack.com/archives/C3EQ7S3MJ/p1748498675962069?thread_ts=1748446854.832469&cid=C3EQ7S3MJ) but it does not work

[Symfony\Component\DependencyInjection\Exception\RuntimeException]                                                                                                                                                    Cannot autowire service"App\Command\TestCommand": argument"$appCache" of method"__construct()" hastype"Symfony\Contracts\Cache\CacheInterface&Symfony\Contracts\Cache\NamespacedPoolInterface" but this class     was not found.