Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DependencyInjection] Defer check for circular references instead of skipping them#59810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm sorry but the test passes without any changes to CheckCircularReferencesPass...
131c0fd toa555225Compare@nicolas-grekas Yep. The service locator was not processed. |
a555225 to124087bCompareGood catch, thanks@biozshock. |
d6e0af4 intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
Allow Dependency injection to check for circular references for lazy services, if they ever appear as "non-lazy" later during the compilation.
The issue happens when one of injected references happen to be in a service locator and injected into another service.