Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] fix multiple transports default injection#59781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

fkropfhamer
Copy link
Contributor

@fkropfhamerfkropfhamer commentedFeb 14, 2025
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#46372
LicenseMIT

As discussed here#46372
If multiple mailer transports are configured and you try to inject the TransportInterface as a service, only the first one gets injected and not all the Transports. Therefore, X-Transport headers do not work.

@fkropfhamerfkropfhamer marked this pull request as ready for reviewFebruary 14, 2025 19:58
@carsonbotcarsonbot added this to the7.3 milestoneFeb 14, 2025
@fkropfhamerfkropfhamerforce-pushed thefix/multiple-mailer-transports branch from4a5472b to5b78ce1CompareFebruary 14, 2025 20:04
@fkropfhamerfkropfhamer changed the base branch from7.3 to7.2February 14, 2025 20:05
@carsonbotcarsonbot changed the titlefix multiple transports default injection[Mailer] fix multiple transports default injectionFeb 14, 2025
@nicolas-grekasnicolas-grekas modified the milestones:7.3,7.2Feb 20, 2025
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should target 6.4 I suppose.

@nicolas-grekasnicolas-grekas modified the milestones:7.2,6.4Feb 20, 2025
@symfonysymfony deleted a comment fromcarsonbotFeb 20, 2025
@symfonysymfony deleted a comment fromcarsonbotFeb 20, 2025
@fabpot
Copy link
Member

Thank you@fkropfhamer.

@fabpotfabpot merged commit4f652a5 intosymfony:6.4Feb 26, 2025
8 of 11 checks passed
@fkropfhamerfkropfhamer deleted the fix/multiple-mailer-transports branchFebruary 26, 2025 10:38
This was referencedFeb 26, 2025
renovatebot added a commit to Runroom/archetype-symfony that referenced this pull requestFeb 28, 2025
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [symfony/framework-bundle](https://symfony.com)([source](https://redirect.github.com/symfony/framework-bundle)) |`7.2.3` -> `7.2.4` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fframework-bundle/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fframework-bundle/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fframework-bundle/7.2.3/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fframework-bundle/7.2.3/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|| [symfony/messenger](https://symfony.com)([source](https://redirect.github.com/symfony/messenger)) | `7.2.3` ->`7.2.4` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fmessenger/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fmessenger/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fmessenger/7.2.3/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fmessenger/7.2.3/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|| [symfony/stopwatch](https://symfony.com)([source](https://redirect.github.com/symfony/stopwatch)) | `7.2.2` ->`7.2.4` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fstopwatch/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fstopwatch/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fstopwatch/7.2.2/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fstopwatch/7.2.2/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|| [symfony/web-profiler-bundle](https://symfony.com)([source](https://redirect.github.com/symfony/web-profiler-bundle)) |`7.2.3` -> `7.2.4` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fweb-profiler-bundle/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fweb-profiler-bundle/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fweb-profiler-bundle/7.2.3/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fweb-profiler-bundle/7.2.3/7.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>symfony/framework-bundle (symfony/framework-bundle)</summary>###[`v7.2.4`](https://redirect.github.com/symfony/framework-bundle/releases/tag/v7.2.4)[CompareSource](https://redirect.github.com/symfony/framework-bundle/compare/v7.2.3...v7.2.4)**Changelog**(symfony/framework-bundle@v7.2.3...v7.2.4)- bug[symfony/symfony#59198](https://redirect.github.com/symfony/symfony/issues/59198)\[Messenger] Filter out non-consumable receivers when registering`ConsumeMessagesCommand` (@&#8203;wazum)- bug[symfony/symfony#59781](https://redirect.github.com/symfony/symfony/issues/59781)\[Mailer] fix multiple transports default injection([@&#8203;fkropfhamer](https://redirect.github.com/fkropfhamer))- bug[symfony/symfony#59829](https://redirect.github.com/symfony/symfony/issues/59829)\[FrameworkBundle] Disable the keys normalization of the CSRF form fieldattributes ([@&#8203;sukei](https://redirect.github.com/sukei))- bug[symfony/symfony#59728](https://redirect.github.com/symfony/symfony/issues/59728)\[Form]\[FrameworkBundle] Use auto-configuration to make the defaultCSRF token id apply only to the app; not to bundles([@&#8203;nicolas-grekas](https://redirect.github.com/nicolas-grekas))</details><details><summary>symfony/messenger (symfony/messenger)</summary>###[`v7.2.4`](https://redirect.github.com/symfony/messenger/releases/tag/v7.2.4)[CompareSource](https://redirect.github.com/symfony/messenger/compare/v7.2.3...v7.2.4)**Changelog**(symfony/messenger@v7.2.3...v7.2.4)- bug[symfony/symfony#59198](https://redirect.github.com/symfony/symfony/issues/59198)\[Messenger] Filter out non-consumable receivers when registering`ConsumeMessagesCommand` (@&#8203;wazum)</details><details><summary>symfony/stopwatch (symfony/stopwatch)</summary>###[`v7.2.4`](https://redirect.github.com/symfony/stopwatch/releases/tag/v7.2.4)[CompareSource](https://redirect.github.com/symfony/stopwatch/compare/v7.2.2...v7.2.4)**Changelog**(symfony/stopwatch@v7.2.3...v7.2.4)-   no significant changes</details><details><summary>symfony/web-profiler-bundle(symfony/web-profiler-bundle)</summary>###[`v7.2.4`](https://redirect.github.com/symfony/web-profiler-bundle/releases/tag/v7.2.4)[CompareSource](https://redirect.github.com/symfony/web-profiler-bundle/compare/v7.2.3...v7.2.4)**Changelog**(symfony/web-profiler-bundle@v7.2.3...v7.2.4)- bug[symfony/symfony#59776](https://redirect.github.com/symfony/symfony/issues/59776)\[WebProfilerBundle] fix rendering notifier message options([@&#8203;xabbuh](https://redirect.github.com/xabbuh))- bug[symfony/symfony#59033](https://redirect.github.com/symfony/symfony/issues/59033)\[WebProfilerBundle] Fix interception for non conventional redirects([@&#8203;Huluti](https://redirect.github.com/Huluti))</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about theseupdates again.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/Runroom/archetype-symfony).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNzYuMiIsInVwZGF0ZWRJblZlciI6IjM5LjE3Ni4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
nicolas-grekas added a commit that referenced this pull requestMay 14, 2025
…on (xabbuh)This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] remove no longer used service definition| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITIn#59781 it was forgotten to remove the definition when an alias with the same name was introduced.Commits-------5940258 remove no longer used service definition
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@jderussejderusseAwaiting requested review from jderusse

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

5 participants
@fkropfhamer@fabpot@nicolas-grekas@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp