NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.3k

[DomCrawler] Bug #43921 Check for null parent nodes in the case of orphaned branches#59779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromttk:crawler-closest-orphan-fix

Feb 14, 2025

Merged

[DomCrawler] Bug #43921 Check for null parent nodes in the case of orphaned branches#59779

fabpot merged 1 commit intosymfony:6.4fromttk:crawler-closest-orphan-fix

Feb 14, 2025

Conversation

Copy link

Contributor

ttk commentedFeb 14, 2025

Q	A
Branch	7.2
Bug fix	yes
New feature	no
Deprecations	no
Issues	Fix#43921
License	MIT

This simple fix checks for null parent nodes when traversing the DOM tree when calling theclosest() function. Instead of failing, the function will return null instead. This bring it into alignment with how theancestors() function behaves (not failing on null parent nodes).

Null parent nodes can occur when a DOM branch is orphaned due to manipulations on the document, and this is a perfectly normal scenario.

Unit tests added that checks for this specific bug.

This fix should not break any backward compatibility.

carsonbot added Status: Needs Review DomCrawler labels

Feb 14, 2025

carsonbot added this to the7.2 milestone

Feb 14, 2025

Copy link

carsonbot commentedFeb 14, 2025

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

carsonbot changed the title~~Bug #43921 [DomCrawler] Check for null parent nodes in the case of orphaned branches~~[DomCrawler] Bug #43921 Check for null parent nodes in the case of orphaned branches

Feb 14, 2025