Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[GHA] fix integration tests#59777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
nicolas-grekas wants to merge1 commit intosymfony:6.4fromnicolas-grekas:gha-fix

Conversation

nicolas-grekas
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Issues-
LicenseMIT

@nicolas-grekas
Copy link
MemberAuthor

@DemigodCode would you mind having a look? Looks like#59751 wasn't quite correct after all ;)

@@ -27,6 +27,25 @@ jobs:
fail-fast: false

services:
frankenphp:
Copy link
MemberAuthor

@nicolas-grekasnicolas-grekasFeb 14, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

reordering because apparently frankenphp is slow to start so we'd benefit from booting it first

@@ -83,15 +102,17 @@ jobs:
REDIS_SENTINEL_QUORUM: 1
redis-primary:
image: redis:latest
hostname: redis-primary
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

invalid entry

ports:
- 16382:6379
command: redis-server --slaveof redis-primary 6379
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

invalid entry also

@DemigodCode
Copy link
Contributor

What happened? The hostname worked correctly in my branch, but it's not necessary.

@xabbuh
Copy link
Member

@DemigodCode looking at the PR it seems that GitHub skipped the integration job (at least I don't see it neither failing nor succeeding)

@DemigodCode
Copy link
Contributor

Now I see, haven't seen what failed.

I'll look into it, it's maybe missing the "replication"=>"predis" option when connecting

@DemigodCode
Copy link
Contributor

So, still fixing the tests. Working code is not affected cause I'm already using it in production ;-)

May have some questions regarding the docker containers in github actions. Will let you know.

nicolas-grekas reacted with heart emoji

@DemigodCode
Copy link
Contributor

Okay, seems like I've got the redis replica configured.

Removed the RedisTest, because Phpredis doesn't support replication. That makes it easier ;-)
PredisRedis is working now except the TagAware. Don't know why. It writes the value in the cache but has() returns false.
That doesn't really belong to my changes and I have no idea why.
We're using Replication with Predis and TagAware and it's working fine.
I guess some kind of replication lag?
I would remove this test too. To check if Predis Replication works for both versions, the PredisRedisReplicationAdapterTest is enough.

If you are fine with that, I would go on and create a PR?

@nicolas-grekas
Copy link
MemberAuthor

Please do yes! Thanks!

@DemigodCode
Copy link
Contributor

Did it in 7.2 again. Currently porting it to 6.4

@DemigodCode
Copy link
Contributor

#59782

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@xabbuhxabbuhxabbuh left review comments

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

4 participants
@nicolas-grekas@DemigodCode@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp