Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Fix compatibility with Twig 3.21#59774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedFeb 14, 2025•
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
Issues-
LicenseMIT

Parser::getExpressionParser() is deprecated since Twig 3.21.

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

When merging this to the 7.3 branch, I suggest bumping the min Twig version of the bridge to 3.21 to allow cleaning the legacy code from there (we cannot do that in 6.4 as we still need to support Twig 2.x anyway).

@fabpot
Copy link
Member

Thank you@alexandre-daubois.

@fabpotfabpot merged commitdb15145 intosymfony:6.4Feb 14, 2025
9 of 10 checks passed
@alexandre-dauboisalexandre-daubois deleted the fix-twig-bridge-compat-3.21 branchFebruary 14, 2025 11:23
nicolas-grekas added a commit that referenced this pull requestFeb 14, 2025
This PR was merged into the 7.3 branch.Discussion----------[TwigBridge] Remove legacy code| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        |Fix#59774 (review)| License       | MITAs suggested in the linked comment.Commits-------ef65035 [TwigBridge] Remove legacy code
This was referencedFeb 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

4 participants
@alexandre-daubois@fabpot@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp