Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Tests for Redis Replication with cache#59751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromDemigodCode:7.2
Feb 11, 2025

Conversation

DemigodCode
Copy link
Contributor

@DemigodCodeDemigodCode commentedFeb 11, 2025•
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#49238
LicenseMIT

Adding Replication of Redis to test config and fix bug

@carsonbotcarsonbot added this to the7.2 milestoneFeb 11, 2025
@carsonbotcarsonbot changed the titleTests for Redis Replication with cache[Cache] Tests for Redis Replication with cacheFeb 11, 2025
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this!
Here is a minor suggestion.
This should target branch 6.4.

@DemigodCode
Copy link
ContributorAuthor

DemigodCode commentedFeb 11, 2025•
edited
Loading

Okay, I've tried to change the base branch, but that seems not to be the change you wanted me to do? :)
Do you want me to do the same in the 6.4 branch and create a new PR?

@nicolas-grekas
Copy link
Member

Thank you@DemigodCode.

DemigodCode reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitd43bac4 intosymfony:6.4Feb 11, 2025
3 of 10 checks passed
@fabpotfabpot mentioned this pull requestFeb 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@jderussejderusseAwaiting requested review from jderusse

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

3 participants
@DemigodCode@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp