Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (seehttps://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
• Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Does this also apply to 6.4?

Please add a testcase

Thank you@davidvancl.
Could you take care of what fabbot reported? And be sure that failing tests are not related to your modifications?

I added a test for empty notes, I don't know why all the tests failed. When I run them locally they pass. Could it be somehow related to CI? also fixed the syntax that was reporting fabbot.@welcoMattic Thank you.

Thank you@davidvancl.

@nicolas-grekas now my tests are failing:

-   <unit name="empty">\n+    <unit name="empty">\n