Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpClient] Fix activity tracking leading to negative timeout errors#59727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromnicolas-grekas:hc-timeout
Feb 10, 2025

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedFeb 7, 2025
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#59041
LicenseMIT

The error case leading to the linked issue is very hard to spot. I won't be able to provide a reproducer nor am I 100% sure that this will fix it. This patch comes solely from logical reasoning so I might have missed something, but hopefully this closes any possibility of passing a negative timeout toself::select().

The fix should be provided by the changed lines about$hasActivity and$lastActivity.
The rest is cleaning / hardening found meanwhile.

@nicolas-grekasnicolas-grekas merged commite1ce353 intosymfony:6.4Feb 10, 2025
9 of 11 checks passed
@nicolas-grekasnicolas-grekas deleted the hc-timeout branchFebruary 12, 2025 15:25
@petski
Copy link

petski commentedFeb 14, 2025
edited
Loading

.. but hopefully this closes ...

FWIW, I was hitting#59041 andee3451b resolved it

nicolas-grekas and xabbuh reacted with hooray emoji

This was referencedFeb 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

3 participants
@nicolas-grekas@petski@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp