Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DependencyInjection] Don't skip classes with private constructor when autodiscovering#59712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
f8da717
to29582b0
CompareDo we still have a compiler pass validating that services are either instantiable classes or have a factory configured, so that we get a clean error at build time for services that miss this configuration ? And if yes, do we need to update its error message to mention the possibility to use |
29582b0
to99830f6
CompareWe do have a compiler pass but it didn't tell about the attribute. PR updated:
|
4d9b7be
intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
With value objects auto-discovery becoming more mainstream (see#59704), it's time to fix registering classes with private constructors.
Those are skipped today but with support for
#[Autoconfigure(constructor: 'createInstance')]
as introduced in#49665, this doesn't make sense anymore.Best reviewedignoring whitespace.