Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Security] Deprecate UserInterface & TokenInterface'seraseCredentials()
#59682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Security] Deprecate UserInterface & TokenInterface'seraseCredentials()
#59682
Uh oh!
There was an error while loading.Please reload this page.
Conversation
012a13f
to2069f53
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
src/Symfony/Component/Security/Core/User/PasswordAuthenticatedUserInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Security/Http/Authentication/AuthenticatorManager.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
2069f53
to40b3696
CompareComments addressed thanks. |
b7d3929
to5df85e4
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This kind of BC layer feels new to me, refreshing :) 👍 with some more minor catches
src/Symfony/Component/Security/Http/Authenticator/RememberMeAuthenticator.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
5df85e4
toe5c94e6
CompareThank you@chalasr. |
5a09d52
intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
This PR was merged into the 7.3 branch.Discussion----------[Ldap] Fix `LdapUser::isEqualTo`| Q | A| ------------- | ---| Branch? | 7.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | Fix#60454| License | MITSince#59682 `LdapUser`s’ password no longer is serialized in the session, which means that `isEqualTo` will crash when trying to access it.This PR makes `getPassword` returns `null` by default to fix this, and update `isEqualTo` to apply#59539’s logic.Commits-------ad74742 [Ldap] Fix `LdapUser::isEqualTo`
Uh oh!
There was an error while loading.Please reload this page.
As promised, this PR adds a commit on top of#59106 to improve the BC layer. This approach didn't fit in a review comment :) /cc@chalasr
This PR leverages the new
#[\Deprecated]
attribute to decide if someeraseCredentials()
method is to be called or not.My target DX here is to save us all (the community) from having to add
erase_credentials: false
configuration in all our apps.So, instead of having to opt-out from the deprecation using this config option, the opt-out is done by adding the attribute on the method:
Before:
After:
This should provide a smoother upgrade path (and maker-bundle could be updated right-away).