Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Scheduler] NormalizeTriggerInterface
asstring
#59679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No opinion on the patch itself. From afar, adding a new class + service looks like a new feature to me but I'm not much into the topic.
src/Symfony/Component/Scheduler/Tests/Messenger/SchedulerTriggerNormalizerTest.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Tests/Messenger/SchedulerTriggerNormalizerTest.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Messenger/Serializer/Normalizer/SchedulerTriggerNormalizer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Messenger/Serializer/Normalizer/SchedulerTriggerNormalizer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Messenger/Serializer/Normalizer/SchedulerTriggerNormalizer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
valtzu commentedFeb 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the review@nicolas-grekas, I have applied all suggestions. Let's wait for@kbond's take on the patch then. I would hope this makes it to 6.4, but since the issue(not being able to use Messenger transports using Symfony Serializer with Scheduler) has existed already over a year, waiting a little bit more (for 7.3) doesn't make a huge difference for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good to me!
I'm not sure on 6.4 vs 7.3. This does fix a bug but does so by adding a new service which feels like a feature.
From themaintenance doc. Strictly following this means this is a feature. |
Ok, thanks, rebased on |
Thank you@valtzu. |
277486a
intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fix the issue with Scheduler & Serializer like@kbond described in#53562 (comment).
Fixes the following error: