Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Scheduler] NormalizeTriggerInterface asstring#59679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromvaltzu:fix-scheduler-stamp
Feb 7, 2025

Conversation

valtzu
Copy link
Contributor

@valtzuvaltzu commentedFeb 3, 2025
edited
Loading

QA
Branch?7.3
Bug fix?yes
New feature?yes
Deprecations?no
IssuesFix#53562
LicenseMIT

Fix the issue with Scheduler & Serializer like@kbond described in#53562 (comment).

Fixes the following error:

Could not decode stamp: The type of the "trigger" attribute for class "Symfony\Component\Scheduler\Generator\MessageContext" must be one of "Symfony\Component\Scheduler\Trigger\TriggerInterface" ("array" given).

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No opinion on the patch itself. From afar, adding a new class + service looks like a new feature to me but I'm not much into the topic.

@valtzu
Copy link
ContributorAuthor

valtzu commentedFeb 4, 2025
edited
Loading

No opinion on the patch itself. From afar, adding a new class + service looks like a new feature to me but I'm not much into the topic.

Thanks for the review@nicolas-grekas, I have applied all suggestions. Let's wait for@kbond's take on the patch then. I would hope this makes it to 6.4, but since the issue(not being able to use Messenger transports using Symfony Serializer with Scheduler) has existed already over a year, waiting a little bit more (for 7.3) doesn't make a huge difference for me.

Copy link
Member

@kbondkbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me!

I'm not sure on 6.4 vs 7.3. This does fix a bug but does so by adding a new service which feels like a feature.

@kbond
Copy link
Member

Adding new classes or non private methods

From themaintenance doc. Strictly following this means this is a feature.

valtzu reacted with eyes emoji

@nicolas-grekasnicolas-grekas modified the milestones:6.4,7.3Feb 5, 2025
@valtzuvaltzu changed the base branch from6.4 to7.3February 5, 2025 18:45
@valtzu
Copy link
ContributorAuthor

Ok, thanks, rebased on7.3 as a new feature.

@fabpot
Copy link
Member

Thank you@valtzu.

@fabpotfabpot merged commit277486a intosymfony:7.3Feb 7, 2025
8 of 11 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@kbondkbondkbond approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Scheduler][Messenger] Message can't be redispatched with Symfony serializer in between
5 participants
@valtzu@kbond@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp