Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpClient] Fix processing a NativeResponse after its client has been reset#59631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM but we don't need these extra comments. The issue can happen in other contexts. The name of the test case LGTM.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
9ad66e5
to0a4521e
CompareThank you@Jean-Beru. |
7e396bb
intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
An exception is thrown in dev when a response is processed before streaming it.
It is due to the HttpClientDataCollectorwhich resets the client between the first access to the response and the next ones. This operation resets the
NativeClientState
and itshosts
property which is used in theNativeReponse
when the stream is cancelled or completed.Reproducer