Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DomCrawler] Don't return file infos for empty file fields#59621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

rudiedirkx
Copy link

@rudiedirkxrudiedirkx commentedJan 26, 2025
edited
Loading

QA
Branch?7.3
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#49014
LicenseMIT

Fixes#49014 but not in a meaningful way IMO. But I don't know where else to remove empty files. Could be inRequest (browser-kit), or even later inMultipartPart (mime). I don't understand why dom-crawler works this way, so I don't know how to fix it correctly.

To do: fix tests..?

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStarkOskarStark changed the title[dom-crawler] Don't return file infos for empty file fieldsDon't return file infos for empty file fieldsJan 27, 2025
@carsonbotcarsonbot changed the titleDon't return file infos for empty file fields[DomCrawler] Don't return file infos for empty file fieldsJan 27, 2025
@nicolas-grekas
Copy link
Member

Let me close as that cannot be the correct solution. The changes in the test cases highlight how this might break existing apps.

nicolas-grekas added a commit that referenced this pull requestFeb 11, 2025
…nicolas-grekas)This PR was merged into the 6.4 branch.Discussion----------[BrowserKit] Fix submitting forms with empty file fields| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#49014| License       | MITReplaces#53586 and#59621Commits-------0fbfc3e [BrowserKit] Fix submitting forms with empty file fields
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

dom-crawler + browser-kit empty file upload error "Path cannot be empty"
4 participants
@rudiedirkx@carsonbot@nicolas-grekas@OskarStark

[8]ページ先頭

©2009-2025 Movatter.jp