Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DomCrawler] Don't return file infos for empty file fields#59621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJan 26, 2025
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Let me close as that cannot be the correct solution. The changes in the test cases highlight how this might break existing apps. |
…nicolas-grekas)This PR was merged into the 6.4 branch.Discussion----------[BrowserKit] Fix submitting forms with empty file fields| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#49014| License | MITReplaces#53586 and#59621Commits-------0fbfc3e [BrowserKit] Fix submitting forms with empty file fields
Uh oh!
There was an error while loading.Please reload this page.
Fixes#49014 but not in a meaningful way IMO. But I don't know where else to remove empty files. Could be in
Request
(browser-kit), or even later inMultipartPart
(mime). I don't understand why dom-crawler works this way, so I don't know how to fix it correctly.To do: fix tests..?