Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] use isRendered method to ensure we can avoid rendering an emai…#59592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

walva
Copy link
Contributor

…l twice

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

Following up my comment onhttps://github.com/symfony/symfony/pull/47075/files.

I would recommend using the method TemplatedEmail::isRendered() the same way it is used inAbstractTransport.php.

Keeping like this prevents subclass of TemplatedEmail with computed html template to not be rendered twice, such asNotificationEmail.

This change will allow developers to create a subclass of template emails and render them before sending them async, without rendering them twice.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@walvawalva changed the base branch from7.3 to6.2January 23, 2025 09:45
@walva
Copy link
ContributorAuthor

@carsonbot I did change the targeting branch

@walva
Copy link
ContributorAuthor

Should I address thisreport ? Because it is a bugfix, I'd like to provide the minimal diff, so my first guess is to not commit more changes.

@stof
Copy link
Member

The 6.2 branch is not maintained anymore. You can see maintained branches onhttps://symfony.com/releases
This PR should target the 6.4 branch.

@walvawalva changed the base branch from6.2 to6.4January 23, 2025 10:15
@walva
Copy link
ContributorAuthor

Thank you@stof

@walvawalva closed thisJan 23, 2025
@walvawalva deleted the fix/cant-render-email-manually branchJanuary 23, 2025 10:43
@walvawalva restored the fix/cant-render-email-manually branchJanuary 23, 2025 10:43
@walva
Copy link
ContributorAuthor

I deleted this PR accidentally. I did open another here:#59596

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

3 participants
@walva@carsonbot@stof
[8]ページ先頭
©2009-2025 Movatter.jp