Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Security] Throw an explicit error when refreshing a token with a null user#59590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromalexandre-daubois:unexpected-value-seccontextJan 28, 2025
Merged
[Security] Throw an explicit error when refreshing a token with a null user#59590
nicolas-grekas merged 1 commit intosymfony:6.4fromalexandre-daubois:unexpected-value-seccontextJan 28, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Could we act earlier and prevent user-less token creation instead? |
f4157ad
to4672786
CompareMoved the condition as early as possible, when we know we deal with a |
nicolas-grekas approved these changesJan 28, 2025
Uh oh!
There was an error while loading.Please reload this page.
4672786
tocd427c3
CompareThank you@alexandre-daubois. |
4d4859a
intosymfony:6.4 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedJan 29, 2025
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follwing#59560 (comment), to prevent the code to simply fail and return an explicit message to the user.