Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Continuation : Add messages on votes#59573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
eltharin wants to merge1 commit intosymfony:7.3fromeltharin:voteObjects

Conversation

eltharin
Copy link
Contributor

@eltharineltharin commentedJan 21, 2025•
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#27995,#26343,#35592,#43147
LicenseMIT

This PR continue the work started by@maidmaid and@noniagriconomie in#35592, continued by@yellow1912 in#43147 continued by@alamirault in#46493.

I rebase on 7.2 and remove deprecation as suggested by nicolas-grekas for not causing backward compatiblity breaks.

It allow to have informations about AccessDecisionManager and Voters (And understand why we have an AccessDeniedException with clear infos).
170878112-f93f8d90-97b7-42f8-8494-603d6b2019e2

After#58107, I take the work from the beginning so I open a new PR.

chapterjason reacted with thumbs up emoji
@carsonbotcarsonbot added this to the7.3 milestoneJan 21, 2025
@eltharineltharin changed the titleadd capability to answer VoteObjectContinuation : Add messages on votesJan 21, 2025
@eltharineltharinforce-pushed thevoteObjects branch 5 times, most recently fromc2c93f2 to41259ddCompareJanuary 21, 2025 21:19
@carsonbotcarsonbot changed the titleContinuation : Add messages on votes[Security] Continuation : Add messages on votesJan 21, 2025
@eltharineltharinforce-pushed thevoteObjects branch 2 times, most recently from126b96b toe8186acCompareJanuary 21, 2025 21:33
@eltharineltharinforce-pushed thevoteObjects branch 5 times, most recently from400a646 toca672e7CompareJanuary 29, 2025 14:27
@nicolas-grekas
Copy link
Member

I'm losing track of the PR I should review.
Please keep one PR and stick to it.
From what I can see, it might be better to continue#58107: this one is a BC break, so a dead end.

@eltharin
Copy link
ContributorAuthor

OK I will merge that on other.
But where do you have a BC? I try with a new/old voter, new/old accesmanager, new/old strategy.
the only BC I think have done is for VoteEvent whitch is internal.
but maybe i miss somewhere...

@nicolas-grekas
Copy link
Member

Changing the return type of a method is a BC break (callers may get results they don't expect.)

@eltharin
Copy link
ContributorAuthor

As you ask, I move all to previous PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Security][DX] Be able to know why exactly SecurityVoter returns false
4 participants
@eltharin@nicolas-grekas@GromNaN@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp