NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.3k

[AssetMapper] Fix CssCompiler matches url in comments#59544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromsmnandre:fix/css-url-import-comment

Jan 25, 2025

Merged

[AssetMapper] Fix CssCompiler matches url in comments#59544

fabpot merged 1 commit intosymfony:6.4fromsmnandre:fix/css-url-import-comment

Jan 25, 2025

Conversation

Copy link

Member

smnandre commentedJan 17, 2025

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix#59512
License	MIT

Add a check to avoid matching url in comments

carsonbot added Status: Needs Review AssetMapper Bug labels

Jan 17, 2025

carsonbot added this to the6.4 milestone

Jan 17, 2025

Copy link

dbannik commentedJan 21, 2025

Please check thetestCase

Fileimages/foo.png should not be contain inexpectedDependencies
becauseurl("images/foo.png"); contain in comment block

yield'ignore_comment_block' => ['input' =><<<CSS        body {            /* background: url("images/foo.png"); */        }        CSS    ,'expectedOutput' =><<<CSS        body {            /* background: url("images/foo.png"); */        }        CSS    ,'expectedDependencies' => [],];

related#59512 (comment)

dbannik mentioned this pull request

Jan 21, 2025

[AssetMapper] Failed to compile CSS when contain invalid path url(...) in comments block#59512

Closed

Copy link

MemberAuthor

smnandre commentedJan 21, 2025

yield'ignore_comment_block_ffs' => ['input' =><<<CSS        body {            /* background: url("images/need-ignore.png"); */        }        CSS    ,'expectedOutput' =><<<CSS        body {            /* background: url("images/need-ignore.png"); */        }        CSS    ,'expectedDependencies' => [],];