Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[JsonEncoder] Allow to warm up object and list#59536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mtarld
Copy link
Contributor

@mtarldmtarld commentedJan 17, 2025•
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
Issues
LicenseMIT

As discussed with@chalasr, configuration in FrameworkBundle must be avoided as much as possible.
That's why#59396 might not be the way to go.

Instead, this PR addresses the most common use cases, which are warming up cache files forGivenClass andlist<GivenClass>.

This can be configured by setting theobject andlist attributes ofjson_encoder.encodable, orasObject andasList of theJsonEncodable attribute accordingly.

@mtarldmtarldforce-pushed thefeat/json-encoder-encode-item-and-list branch from322cc5b to90ca852CompareJanuary 17, 2025 16:34
@mtarldmtarld changed the title[JsonEncoder] Allow to warm up item and list[JsonEncoder] Allow to warm up object and listJan 17, 2025
@nicolas-grekas
Copy link
Member

Maybe missing changelog entry?
Also an example / snippet in the PR description that could help bootstrap the doc / a blog post mentionning this?

@mtarldmtarldforce-pushed thefeat/json-encoder-encode-item-and-list branch from90ca852 tocb36ec0CompareJanuary 23, 2025 08:20
@fabpot
Copy link
Member

Thank you@mtarld.

@fabpotfabpot merged commit1f83bf1 intosymfony:7.3Jan 25, 2025
5 of 11 checks passed
@mtarldmtarld deleted the feat/json-encoder-encode-item-and-list branchJanuary 25, 2025 08:39
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@GromNaNGromNaNGromNaN approved these changes

@chalasrchalasrchalasr approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

6 participants
@mtarld@nicolas-grekas@fabpot@GromNaN@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp