Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] [AMQP] Add TransportMessageIdStamp logic for AMQP#59526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

AurelienPillevesse
Copy link
Contributor

@AurelienPillevesseAurelienPillevesse commentedJan 16, 2025•
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

UseTransportMessageIdStamp for AMQP bridge like Doctrine bridge for example.

Implement it inAmqpSender asDoctrineSender (https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/DoctrineSender.php#L51)
Implement it inAmqpReceiver asDoctrineReceiver (https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/DoctrineReceiver.php#L148)

With this update, logger for AMQP will have more context withmessage_id data (https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php#L55)

@AurelienPillevesse
Copy link
ContributorAuthor

Errors are not related to this PR

@AurelienPillevesse
Copy link
ContributorAuthor

I choose 7.3 but I don't know if it's a new feature or not (because already present in other transports).
If you want to merge it to 7.2, it's OK for me.
@nicolas-grekas

@fabpotfabpotforce-pushed theadd-amqp-transport-message-id-stamp-logic branch frome326e92 to4bcb380CompareFebruary 17, 2025 09:08
@fabpot
Copy link
Member

Thank you@AurelienPillevesse.

AurelienPillevesse reacted with rocket emoji

@fabpotfabpot merged commitf48e068 intosymfony:7.3Feb 17, 2025
5 checks passed
@AurelienPillevesseAurelienPillevesse deleted the add-amqp-transport-message-id-stamp-logic branchFebruary 17, 2025 09:11
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

4 participants
@AurelienPillevesse@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp