Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] [Smtp] Add DSN param to enforce TLS/STARTTLS#59479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.3fromssddanbrown:mailer_require_tls
Feb 11, 2025

Conversation

ssddanbrown
Copy link
Contributor

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#48297
LicenseMIT

Adds 'require_tls' param which can be set to true to enforce the use of TLS/STARTTLS within the ESMTP transport.
This was discussed in#48297.
These changes are based upon patchesI've been maintaining for my own projects.

This is my first PR to Symfony, I've tried to follow the guide as best as possible, and I was also using#53621 as a general guide. There are some other ways I could have gone about things, but I've tried to avoid touching as much existing Symfony code as possible.

In#48297, nicolas-grekas mentioned unifying such an option withauto_tls under atls option, but I think these are distinct options which may not be as clear combined (in addition to any expectations of such an option disabling/enabling TLS in general).

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@ssddanbrownssddanbrownforce-pushed themailer_require_tls branch 2 times, most recently frombd5e626 toeae0ffeCompareJanuary 20, 2025 11:40
@ssddanbrown
Copy link
ContributorAuthor

Thanks for the review@mtarld.
I've now addressed both of the raised points, and have re-based the branch to the current 7.3 state.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

We need to make it clear in the doc that this option makes sense with the "smtp" scheme (since TLS is always enabled with "smtps" anyway).

mdoutreluingne reacted with thumbs up emoji
Adds 'require_tls' param which can be set to true to enforcethe use of TLS/STARTTLS within the ESMTP transport.
@nicolas-grekas
Copy link
Member

Thank you@ssddanbrown.

@nicolas-grekasnicolas-grekas merged commitaf2df09 intosymfony:7.3Feb 11, 2025
9 of 11 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestMay 8, 2025
This PR was squashed before being merged into the 7.3 branch.Discussion----------[Mailer] Document `require_tls` optionFor#20644. This PR documents the added SMTP `require_tls` option, as introduced insymfony/symfony#59479.I have referenced that this could throw a `TransportException` (where TLS is not achieved) but not sure if I should instead reference `TransportExceptionInterface`.Commits-------55217dc [Mailer] Document `require_tls` option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mtarldmtarldmtarld requested changes

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Mailer] Option to enforce STARTTLS
5 participants
@ssddanbrown@carsonbot@nicolas-grekas@fabpot@mtarld
[8]ページ先頭
©2009-2025 Movatter.jp