Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] Fix configuring a single route's hosts#59446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromMatTheCat:ticket_58086
Jan 9, 2025

Conversation

MatTheCat
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58086
LicenseMIT

All loaders were affected by this issue: when you configure a route it is immediately added to the main collectionand in the one returned by theLocalizedRouteTrait. Problem is: only the latter is updated when configuring hosts, which means they will be ignored.

This PR merges these two collections, with a twist: after its hosts are configured, a route may have to be removed from the main collection (likestatic becomingstatic.nl andstatic.en in the tests).

@nicolas-grekasnicolas-grekas changed the title[Routing] Fix configuring a single route’ hosts[Routing] Fix configuring a single route's hostsJan 9, 2025
@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

@nicolas-grekasnicolas-grekas merged commita6ead57 intosymfony:6.4Jan 9, 2025
11 checks passed
@MatTheCatMatTheCat deleted the ticket_58086 branchJanuary 9, 2025 15:32
This was referencedJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

3 participants
@MatTheCat@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp