Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[VarDumper] Fix blank strings display#59390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromMatTheCat:ticket_57980
Jan 9, 2025

Conversation

MatTheCat
Copy link
Contributor

@MatTheCatMatTheCat commentedJan 7, 2025
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#57980
LicenseMIT

Becausesf-dump-ellipsisspans needed atext-ellipsis, their overflowing content was cut usingoverflow: hidden. As it required their inner display type to beblock, this broke the alignment with the ellipsis’ “tail”. This was fixed by#53147 by making every dump’sspansinline-flex.

This change madesf-dump-ellipsisdisplay,max-width andvertical-align properties useless so this PR removes them, as well as a duplicatedoverflow one.

Now,inline-flex elements’ content becomes flex items, which caused#57980 because

if the entire sequence of [a flex item’s] text runs contains only white space […] it is […] not rendered

https://www.w3.org/TR/css-flexbox-1/#flex-items

Instead of making every dump’sspansinline-flex, this PR targets a newsf-dump-ellipsization class added tosf-dump-ellipsis’ parents.

It also wraps ellipsis tails with elements bearing thesf-dump-ellipsis-tail class so that we can prevent them to shrink:

Before:

After:

@carsonbotcarsonbot added this to the6.4 milestoneJan 7, 2025
@MatTheCatMatTheCatforce-pushed theticket_57980 branch 5 times, most recently from7b693f2 to4a43badCompareJanuary 7, 2025 11:07
"<pre class=sf-dump id=sf-dump data-indent-pad=\" \"><span class=sf-dump-num>123</span>\n</pre><script>Sfdump(\"sf-dump\")</script>\n"
."<pre class=sf-dump id=sf-dump data-indent-pad=\" \"><span class=sf-dump-num>456</span>\n</pre><script>Sfdump(\"sf-dump\")</script>\n",
"<pre class=sf-dump id=sf-dump data-indent-pad=\" \"><span class=\"sf-dump-num\">123</span>\n</pre><script>Sfdump(\"sf-dump\")</script>\n"
."<pre class=sf-dump id=sf-dump data-indent-pad=\" \"><span class=\"sf-dump-num\">456</span>\n</pre><script>Sfdump(\"sf-dump\")</script>\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this change breaks low-deps
better preserve the previous output when possible to not have to change version constraints
doable?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think I could quote theclass attribute only if there are two indeed (would feel weird though 😅)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

that'd help fix tests (they're still red :) )

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wouldn’t high and low-deps tests eventually pass when the code is released?

Anyways, I limited the changes to ellipsization so that other components’ tests are not impacted 🟢

@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

@nicolas-grekasnicolas-grekas merged commit89ba0e5 intosymfony:6.4Jan 9, 2025
11 checks passed
@MatTheCatMatTheCat deleted the ticket_57980 branchJanuary 9, 2025 15:32
This was referencedJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

3 participants
@MatTheCat@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp