Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] fix inline notation with inline comment#59381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

alexpott
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#59378
LicenseMIT

Recent commit broke parsing yam like:

calls:# This is a temporary measure. JSON:API should not need to be aware of the Content Moderation module.  -[setLatestRevisionCheck, ['@?access_check.latest_revision']]# This is only injected when the service is available.

This MR adds a test and fixes this.

@carsonbotcarsonbot added this to the7.3 milestoneJan 6, 2025
@alexpottalexpott changed the base branch from7.3 to6.4January 6, 2025 23:36
@carsonbotcarsonbot changed the title59378 fix inline notation with inline comment[Yaml] 59378 fix inline notation with inline commentJan 7, 2025
@nicolas-grekasnicolas-grekas changed the title[Yaml] 59378 fix inline notation with inline comment[Yaml] fix inline notation with inline commentJan 7, 2025
@nicolas-grekasnicolas-grekas modified the milestones:7.3,6.4Jan 7, 2025
@symfonysymfony deleted a comment fromcarsonbotJan 7, 2025
@nicolas-grekasnicolas-grekasforce-pushed the59378-fix-inline-notation-with-inline-comment branch from1fc3b02 todccac0bCompareJanuary 7, 2025 09:44
@nicolas-grekas
Copy link
Member

Thank you@alexpott.

@nicolas-grekasnicolas-grekas merged commit82011ee intosymfony:6.4Jan 7, 2025
11 checks passed
This was referencedJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@xabbuhxabbuhxabbuh approved these changes

@maxbeckersmaxbeckersmaxbeckers approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@ycerutoycerutoAwaiting requested review from yceruto

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

Inline yaml comments broken after recent commit
5 participants
@alexpott@nicolas-grekas@xabbuh@maxbeckers@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp