Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[RemoteEvent][Webhook] FixSendgridRequestParser andSendgridPayloadConverter#59376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromericabouaf:fix_sendgrid_missing_message_idJan 7, 2025
Merged
[RemoteEvent][Webhook] FixSendgridRequestParser andSendgridPayloadConverter#59376
nicolas-grekas merged 1 commit intosymfony:6.4fromericabouaf:fix_sendgrid_missing_message_idJan 7, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…verter in case of missing sg_message_id
SendgridRequestParser andSendgridPayloadConverterThank you@ericabouaf. |
d6fa9a8 intosymfony:6.4 10 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedJan 29, 2025
Merged
Merged
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According tohttps://www.twilio.com/docs/sendgrid/for-developers/tracking-events/event#event-objects, not all webhook events contains a
sg_message_idin the payload. In the case of a delayed orasynchronous bounce, the message ID will be unavailable.The current implementation rejects the webhook call with "Payload is malformed".
We should use the always present
sg_event_idinstead.For BC reasons, I did not want to change the id of the RemoteEvent, so I kept
sg_message_idif present, but fallback tosg_event_idinstead so that the webhook is not rejected.