Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Lock] Fix predis command error checking#59348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9b0ae19 to4816402Comparero0NL approved these changesJan 3, 2025
fabpot approved these changesJan 4, 2025
Thank you@dciprian-petrisor. |
b048d76 intosymfony:7.2 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
nicolas-grekas added a commit that referenced this pull requestFeb 4, 2025
This PR was merged into the 7.2 branch.Discussion----------[Lock] Fix Predis error handling| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#59686| License | MIT#59348 completely broke the Redis store when used with a service, eg:```yamlframework: lock: resources: default: snc_redis.default```The assumption that `exceptions` is always `false` is only correct when a DSN is used.Commits-------b20892f [Lock] Fix Predis error handling
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We seem to have had an incompatibility with how Predis clients are initialized (
'exceptions' => false) and the implementation of RedisStore, which only surfaced now due to the recent EVAL -> EVALSHA changes.According tohttps://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Cache/Traits/RedisTrait.php#L65 and
https://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Cache/Traits/RedisTrait.php#L419 , the Predis client is always initialized with exceptions disabled; it returns Error objects instead.
This PR fixes the tests to replicate this behaviour and the implementation.
An small additional change was made regarding error checking, to ensure the initial
evalShadoes not fail with anything else besides the expectedNOSCRIPTerror.