Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ErrorHandler] [A11y] Simple proposal for color updates on error stack traces against colorblindness#59334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromDocFX:patch-1
Jan 1, 2025

Conversation

DocFX
Copy link
Contributor

QA
Branch?7.3
Bug fix?no
New feature?no
Deprecations?no
IssuesN/A
LicenseMIT

Hi!

I'm colorblind, slightly. I know it can be a real headache to try colors that can match all colorblindnesses, it's a nightmare, as a lot of them are opposed and as some fixes can actually make things worse for other people.

I just open this with a very small changeset in colors for stack traces. The rest of the debug pages seem OK to me (profiler, tables, etc.). But currently I'm really struggling to read the highlighted lines and the dark red PHP syntax highlighting for native identifiers.

I only changed those colors, trying to make it better.
Feel free to discuss better proposals, like using the WebAIM WCAG 2.0 checker (https://webaim.org/resources/contrastchecker/).

Background to red text:https://webaim.org/resources/contrastchecker/?fcolor=FF7B72&bcolor=2E3136

Highlight to PHP identifiers will fail, but it's almost impossible without changing all colors. 1.94/1 is still acceptable as most characters are non-word:https://webaim.org/resources/contrastchecker/?fcolor=71663ACC&bcolor=FF7B72

If anyone thinks we can come up with better proposals, there you go!
At least this fixes it for me and non-colorblind people around me seem to find it still readable, if not better, too. :)

@OskarStark
Copy link
Contributor

OskarStark commentedDec 31, 2024
edited
Loading

Thank you, can you add some before and after screenshots?

welcoMattic reacted with thumbs up emoji

@carsonbotcarsonbot changed the title[A11y] Simple proposal for color updates on error stack traces against colorblindness[ErrorHandler] [A11y] Simple proposal for color updates on error stack traces against colorblindnessDec 31, 2024
@DocFX
Copy link
ContributorAuthor

Thank you, can you add some before and after screenshots?

Sure! Here's a first try!

Before:

{7E624852-1540-4AEB-BDD4-F5125D65D3D0}

Aftercommit:

{B536BA5A-47D3-44BC-AB20-DAE1E08518CB}
OskarStark reacted with heart emoji

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would also vote to merge this as a bugfix.

OskarStark reacted with thumbs up emoji
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As a bugfix

@fabpot
Copy link
Member

Definitely a bug fix.

@fabpotfabpot modified the milestones:7.3,6.4Jan 1, 2025
@fabpot
Copy link
Member

Thank you@DocFX.

DocFX reacted with thumbs up emoji

@fabpotfabpot merged commit006bbba intosymfony:6.4Jan 1, 2025
11 checks passed
This was referencedJan 29, 2025
@fabpotfabpot mentioned this pull requestJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

6 participants
@DocFX@OskarStark@fabpot@xabbuh@yceruto@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp