Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpClient] fix amphp http client v5 unix socket#59320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -160,7 +161,7 @@ public function connect(SocketAddress|string $uri, ?ConnectContext $context = nu | |||
| if ($options['proxy']) { | |||
| $proxyUrl = parse_url($options['proxy']['url']); | |||
| $proxySocket = new SocketAddress($proxyUrl['host'], $proxyUrl['port']); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this class are not exist in v5
Uh oh!
There was an error while loading.Please reload this page.
@nicolas-grekas psalm check fail because it run using php 8.2 and amphp/httpclient v4, should I surpress undefined method error? |
No need to, just ignore the message. |
18b6d64 toa32ebfaCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I moved the test case to HttpClientTestCase to that we run it with curl also.
Thank you@praswicaksono. |
89cd804 intosymfony:7.2Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fix unix socket connection when using
amphp/http-clientv5@nicolas-grekas