Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Yaml] Fix parsing of unquoted strings in Parser::lexUnquotedString() to ignore spaces#59312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedDec 28, 2024
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| public function testWrappedUnquotedStringWithMultipleSpacesInValue(string $yaml, array $expected) | ||
| { | ||
| $this->assertSame($expected, $this->parser->parse($yaml)); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please add a blank line after the closing curly brace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
with some minor CS remarks
| { | ||
| $this->assertSame($expected, $this->parser->parse($yaml)); | ||
| } | ||
| public static function WrappedUnquotedStrings() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| publicstaticfunctionWrappedUnquotedStrings() { | |
| publicstaticfunctionwrappedUnquotedStringsProvider() | |
| { |
| @@ -1710,6 +1710,32 @@ public function testBackslashInQuotedMultiLineString() | |||
| $this->assertSame($expected, $this->parser->parse($yaml)); | |||
| } | |||
| /** | |||
| * @dataProvider WrappedUnquotedStrings | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| * @dataProviderWrappedUnquotedStrings | |
| * @dataProviderwrappedUnquotedStringsProvider |
| } | ||
| public static function WrappedUnquotedStrings() { | ||
| return [ | ||
| 'CurlyBraces' => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| 'CurlyBraces' => [ | |
| 'mapping' => [ |
| 'fiz' => 'cat cat', | ||
| ] | ||
| ], | ||
| 'SquareBraces' => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| 'SquareBraces' => [ | |
| 'sequence' => [ |
@xabbuh Thank you for taking the time to review my PR! I really appreciate your feedback and have made the suggested changes. Let me know if there's anything else to adjust! |
Thank you@Link1515. |
96941db intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
I modified the
strcspn()call in thelexUnquotedString()method of theParserclass to exclude the space character (' ') from the list of delimiters. This ensures that spaces are no longer considered while parsing unquoted strings.